Feature/slac api #1570
Open
Feature/slac api #1570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added slac_API module - External API for SLAC * Added BUSlac module - BringUp module for SLAC * Added API documentation Signed-off-by: Piet Gömpel <[email protected]>
Signed-off-by: Piet Gömpel <[email protected]>
Pietfried
requested review from
SebaLukas,
andistorm,
cburandt,
corneliusclaussen,
djchhp,
hikinggrass,
james-ctc and
mlitre
as code owners
Contributor
Author
|
@djchhp all changes of the original PR had been adressed. |
james-ctc
reviewed
Dec 4, 2025
| }); | ||
|
|
||
| screen.Loop(main_renderer); | ||
| } |
Member
There was a problem hiding this comment.
Is it documented somewhere that ready() doesn't need to return?
Other than in the bringup modules I've not seen this pattern. My concern is that it is making an assumption about how the framework works.
Contributor
Author
There was a problem hiding this comment.
Afaik it's not documented. The documentation of the framework including startup behavior, module communication, cmd/var handling, etc. should in general be improved. I created an issue for this: #1613
james-ctc
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Added support for external slac API module:
Issue ticket number and link
Original PR: #1463
Checklist before requesting a review